Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nijil / GRWT-5310 / Remove max ticks from contract card in open positions and contract details page in DTrader #18131

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Nijil / GRWT-5310 / Remove max ticks from contract card in open positions and contract details page in DTrader #18131

wants to merge 3 commits into from

Conversation

nijil-deriv
Copy link
Contributor

@nijil-deriv nijil-deriv commented Mar 12, 2025 •
edited
Loading

Changes:

Remove max ticks from contract card in open positions and contract details page in DTrader

Screenshots:

Screenshot 2025-03-12 at 2 39 27 PM
Screenshot 2025-03-12 at 2 39 09 PM

@vercel Vercel
Copy link

vercel bot commented Mar 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 13, 2025 9:48am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/deriv-com/deriv-app/pull/18131](https://github.com/deriv-com/deriv-app/pull/18131)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nijil-deriv-nijil-grwt-5310remove-max-ticks.binary.sx?qa_server=red.derivws.com&app_id=32479
    - **Original**: https://deriv-app-git-fork-nijil-deriv-nijil-grwt-5310remove-max-ticks.binary.sx
- **App ID**: `32479`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025 •
edited
Loading

⏳ Generating Lighthouse report...

vinu-deriv
vinu-deriv previously approved these changes Mar 13, 2025
View reviewed changes
vinu-deriv
vinu-deriv previously approved these changes Mar 13, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinu-deriv vinu-deriv vinu-deriv approved these changes

@kate-deriv kate-deriv kate-deriv approved these changes

@amina-deriv amina-deriv Awaiting requested review from amina-deriv amina-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@habib-deriv habib-deriv Awaiting requested review from habib-deriv habib-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nijil-deriv @vinu-deriv @kate-deriv